feat: remove tags difference [CLK-493280] #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 72.54% 71.90% -0.65%
==========================================
Files 3 3
Lines 102 121 +19
Branches 17 20 +3
==========================================
+ Hits 74 87 +13
- Misses 26 32 +6
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
ahammond
approved these changes
Apr 30, 2024
jose-clickup
deleted the
Jose-Amoroso/CLK-493280/Add-option-to-remove-tags-from-cdk-diff-to-reduce-gh-comments-noise
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #CLK-493280
Library version tags introduced noise on
cdk-diffoutputs on PRs, diminishing the capability to review stack changes on comments quickly. E.g: https://github.com/time-loop/content-processor-cdk/pull/57#issuecomment-2081746467. This PR removes Tags diff with regex and also adds a note in case of tags diff so that the reviewer can find the complete diff output in GH actions logs.